Bump Ubuntu 14.04 to 16.04. #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burrbull
approved these changes
Nov 27, 2019
|
bors try |
tryBuild succeeded |
Dylan-DPC-zz
approved these changes
Nov 28, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 28, 2019
353: Bump Ubuntu 14.04 to 16.04. r=Dylan-DPC a=reitermarkus Images started failing to build with Ubuntu 14.04. This is a breaking change, but the next version will be 0.2.0 in any case. This brings up the question whether we should just bump all images to use 18.04 so we can have a common base image for all of them. To keep supporting the oldest version is clearly not feasible in the long run since images will keep breaking. Co-authored-by: Markus Reiter <me@reitermark.us>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Images started failing to build with Ubuntu 14.04.
This is a breaking change, but the next version will be 0.2.0 in any case.
This brings up the question whether we should just bump all images to use 18.04 so we can have a common base image for all of them. To keep supporting the oldest version is clearly not feasible in the long run since images will keep breaking.