Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mips64-unknown-linux-muslabi64 and mips64el-unknown-linux-muslabi64 support #647

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Add mips64-unknown-linux-muslabi64 and mips64el-unknown-linux-muslabi64 support #647

merged 1 commit into from
Mar 17, 2022

Conversation

abcfy2
Copy link
Contributor

@abcfy2 abcfy2 commented Mar 14, 2022

Fix #503

Reopen from #507

@abcfy2 abcfy2 requested a review from a team as a code owner March 14, 2022 15:03
@reitermarkus
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Mar 14, 2022
@bors
Try #647:
879dc24
@bors
Copy link
Contributor

bors bot commented Mar 14, 2022

try

Build failed:

@abcfy2 abcfy2 force-pushed the main branch 3 times, most recently from 3c47a7a to d11e944 Compare March 15, 2022 09:48
@reitermarkus
Copy link
Member

Please add a changelog entry and fix the missing newlines in the Dockerfiles.

@abcfy2
Copy link
Contributor Author

abcfy2 commented Mar 15, 2022

Please add a changelog entry and fix the missing newlines in the Dockerfiles.

How do I add changelog. Is there any examples ?

@reitermarkus
Copy link
Member

In CHANGELOG.md, add a new line under the “Unreleased” section.

@abcfy2
Copy link
Contributor Author

abcfy2 commented Mar 16, 2022

Got it.

@reitermarkus
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Mar 16, 2022
@bors
Try #647:
1184f1b
@bors
Copy link
Contributor

bors bot commented Mar 16, 2022

try

Build failed:

@abcfy2
Copy link
Contributor Author

abcfy2 commented Mar 17, 2022

Rebase from main branch, and test should be fixed.

@Emilgardis
Copy link
Member

bors try --target mips64

bors bot added a commit that referenced this pull request Mar 17, 2022
@bors
Try #647: --target mips64
705a196
@bors
Copy link
Contributor

bors bot commented Mar 17, 2022

try

Build succeeded:

Emilgardis
Emilgardis approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 17, 2022

Build succeeded:

@bors bors bot merged commit 81215fd into cross-rs:main Mar 17, 2022
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
A-mips Area: MIPS targets container-images enhancement
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.

Support mips64-unknown-linux-muslabi64 and mips64el-unknown-linux-muslabi64
4 participants
@abcfy2 @reitermarkus @Emilgardis @Alexhuszagh