Use host target directory when calling host cargo. #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using docker, the target directory is mounted at `/target`. However, when falling back to the host cargo, if we provide a custom target directory, we incorrectly pass it as `--target-dir /target`. To rectify this, this PR passes the original command-line arguments to cargo. Fixes cross-rs#619.
Emilgardis
requested changes
May 24, 2022
Remove unnecessary detail in comment. Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
|
Build succeeded: |
Alexhuszagh
added
bug
no-ci-targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using docker, the target directory is mounted at
/target. However, when falling back to the host cargo, if we provide a custom target directory, we incorrectly pass it as--target-dir /target. To rectify this, this PR passes the original command-line arguments to cargo.Fixes #619.