Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: latest librocksdb is not used #1010

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Sep 4, 2023

Solution:

  • bump deps

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner September 4, 2023 06:54
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
nix/rocksdb.nix Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
@yihuang yihuang requested a review from mmsqe September 4, 2023 07:30
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +3.00% 🎉

Comparison is base (fd98c7e) 30.04% compared to head (63152ec) 33.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1010      +/-   ##
==========================================
+ Coverage   30.04%   33.05%   +3.00%     
==========================================
  Files         125      126       +1     
  Lines       20012    20014       +2     
==========================================
+ Hits         6013     6616     +603     
+ Misses      12955    12339     -616     
- Partials     1044     1059      +15     
Flag Coverage Δ
integration_tests 20.67% <ø> (ø)
integration_tests_byzantine 9.65% <ø> (+0.01%) ⬆️
integration_tests_gov 9.97% <ø> (ø)
integration_tests_grpc 9.95% <ø> (ø)
integration_tests_ibc 24.77% <ø> (ø)
integration_tests_ledger 9.84% <ø> (ø)
integration_tests_slow 9.84% <ø> (ø)
integration_tests_solomachine 9.63% <ø> (ø)
integration_tests_upgrade 9.95% <ø> (ø)
unit_tests 10.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yihuang yihuang added this pull request to the merge queue Sep 15, 2023
Merged via the queue into crypto-org-chain:master with commit 9758d87 Sep 15, 2023
30 of 31 checks passed
@yihuang yihuang deleted the rocksdb-8.5 branch September 15, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants