Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: multi-sign batch command is not exposed and tested (#422) #438

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

linfeng-crypto
Copy link
Contributor

solution: add multisign-batch in tx subcommand and integration test

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #438 (d9bb0d6) into master (252069b) will increase coverage by 2.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
+ Coverage   20.74%   22.94%   +2.19%     
==========================================
  Files          54       54              
  Lines        8565     8682     +117     
==========================================
+ Hits         1777     1992     +215     
+ Misses       6213     6119      -94     
+ Partials      575      571       -4     
Flag Coverage Δ
integration_tests 20.73% <100.00%> (-0.02%) ⬇️
unit_tests 11.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/chain-maind/app/app.go 52.94% <100.00%> (+0.25%) ⬆️
app/app.go 18.38% <0.00%> (-73.93%) ⬇️
config/config.go 55.55% <0.00%> (-11.12%) ⬇️
x/subscription/keeper/keeper.go 79.09% <0.00%> (+18.18%) ⬆️
x/subscription/types/calendar.go 88.88% <0.00%> (+26.38%) ⬆️
x/subscription/types/bitset.go 100.00% <0.00%> (+47.61%) ⬆️
x/subscription/types/cronspec.go 86.78% <0.00%> (+62.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 252069b...d9bb0d6. Read the comment docs.

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomtau tomtau self-requested a review March 30, 2021 05:23
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the liquid supply test fails: https://github.com/crypto-org-chain/chain-main/pull/438/checks?check_run_id=2224687315#step:5:389
I guess because 4000cro were added to the default network?

@linfeng-crypto
Copy link
Contributor Author

the liquid supply test fails: https://github.com/crypto-org-chain/chain-main/pull/438/checks?check_run_id=2224687315#step:5:389
I guess because 4000cro were added to the default network?

I'll check

@tomtau tomtau self-requested a review March 30, 2021 10:28
@tomtau tomtau merged commit 9e37278 into crypto-org-chain:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants