Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: default gRPC init configuration bound to 0.0.0.0 #665

Merged
merged 5 commits into from
Oct 25, 2021
Merged

Problem: default gRPC init configuration bound to 0.0.0.0 #665

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4700b1c
Fix #586 - Bound gGPRC address to 127.0.0.1
damoncro Oct 20, 2021
6435af1
Change 127.0.0.0 to 127.0.0.1
damoncro Oct 20, 2021
ae00c5b
Add customAppConfig support
damoncro Oct 22, 2021
56f263b
This reverts commit 6435af and 4700b1c
damoncro Oct 22, 2021
526f1db
Fix Error: File is not `gofmt`-ed with `-s`
damoncro Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion cmd/chain-maind/app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"time"

conf "github.com/cosmos/cosmos-sdk/client/config"
serverconfig "github.com/cosmos/cosmos-sdk/server/config"

"github.com/imdario/mergo"
"github.com/spf13/cast"
Expand Down Expand Up @@ -74,7 +75,9 @@ func NewRootCmd() (*cobra.Command, params.EncodingConfig) {
return err
}

return server.InterceptConfigsPreRunHandler(cmd, "", nil)
customAppTemplate, customAppConfig := initAppConfig()

return server.InterceptConfigsPreRunHandler(cmd, customAppTemplate, customAppConfig)
},
}

Expand All @@ -83,6 +86,28 @@ func NewRootCmd() (*cobra.Command, params.EncodingConfig) {
return rootCmd, encodingConfig
}

// initAppConfig helps to override default appConfig template and configs.
// return "", nil if no custom configuration is required for the application.
func initAppConfig() (string, interface{}) {
// The following code snippet is just for reference.

type CustomAppConfig struct {
serverconfig.Config
}

// Optionally allow the chain developer to overwrite the SDK's default
// server config.
srvCfg := serverconfig.DefaultConfig()
srvCfg.GRPC.Address = "127.0.0.1:9090"
srvCfg.GRPCWeb.Address = "127.0.0.1:9091"

customAppConfig := CustomAppConfig{
Config: *srvCfg,
}

return serverconfig.DefaultConfigTemplate, customAppConfig
}

func initRootCmd(rootCmd *cobra.Command, encodingConfig params.EncodingConfig) {
// authclient.Codec = encodingConfig.Marshaler
cfg := sdk.GetConfig()
Expand Down