Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: The embed swagger-ui is not up to date #678

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Nov 23, 2021

Solution:

  • Update to v4.1.0

๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! ๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #678 (395f411) into master (0f99b25) will increase coverage by 4.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
+ Coverage   18.60%   22.62%   +4.02%     
==========================================
  Files          69       70       +1     
  Lines        7946     8018      +72     
==========================================
+ Hits         1478     1814     +336     
+ Misses       5982     5665     -317     
- Partials      486      539      +53     
Flag Coverage ฮ”
integration_tests 19.38% <รธ> (+0.78%) โฌ†๏ธ
unit_tests 9.57% <รธ> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage ฮ”
app/docs/statik/statik.go 100.00% <รธ> (รธ)
app/app.go 17.94% <0.00%> (-72.06%) โฌ‡๏ธ
x/supply/keeper/keeper.go 84.09% <0.00%> (-8.77%) โฌ‡๏ธ
x/nft/client/rest/tx.go 2.85% <0.00%> (-4.65%) โฌ‡๏ธ
x/nft/simulation/decoder.go 0.00% <0.00%> (รธ)
x/nft/simulation/operations.go 0.00% <0.00%> (รธ)
x/nft/types/events.go
x/nft/types/denom.go 100.00% <0.00%> (รธ)
x/nft/types/tx.pb.go 23.38% <0.00%> (+0.50%) โฌ†๏ธ
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data
Powered by Codecov. Last update 0f99b25...395f411. Read the comment docs.

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likely ok, probably also need to add swagger's license to notices

@tomtau tomtau merged commit 785db15 into crypto-org-chain:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants