Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: query nft owner returns error when user has NFTs transferred over IBC #903

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

devashishdxt
Copy link
Collaborator

@devashishdxt devashishdxt commented Nov 29, 2022

Solution: Fixed denomID and tokenID splitting logic when denom has ibc. Fixes #901.

…ed over IBC.

Solution: Fixed denomID and tokenID splitting logic when denom has `ibc`.
@devashishdxt devashishdxt requested a review from a team as a code owner November 29, 2022 01:12
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #903 (26925c8) into master (0192445) will increase coverage by 0.29%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #903      +/-   ##
==========================================
+ Coverage   16.67%   16.96%   +0.29%     
==========================================
  Files         118      119       +1     
  Lines       14156    14265     +109     
==========================================
+ Hits         2360     2420      +60     
- Misses      11322    11365      +43     
- Partials      474      480       +6     
Flag Coverage Δ
integration_tests 14.46% <0.00%> (+0.10%) ⬆️
unit_tests 5.95% <66.66%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
x/nft/types/keys.go 70.21% <66.66%> (+11.23%) ⬆️
app/state.go 0.00% <0.00%> (ø)
x/nft/genesis.go 0.00% <0.00%> (ø)
x/nft/simulation/operations.go 0.00% <0.00%> (ø)
x/icaauth/types/params.go
x/nft-transfer/types/ack.go 0.00% <0.00%> (ø)
app/params/proto.go 100.00% <0.00%> (ø)
x/nft/client/cli/tx.go 74.19% <0.00%> (+0.31%) ⬆️
x/nft/keeper/querier.go 10.60% <0.00%> (+1.62%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SplitKeyDenom is only used in gRPC (Owner) -- is that via any path used on the consensus-related logic, i.e. is this a breaking change?

@devashishdxt
Copy link
Collaborator Author

SplitKeyDenom is only used in gRPC (Owner) -- is that via any path used on the consensus-related logic, i.e. is this a breaking change?

This is only used in gRPC query. This is not a breaking change.

@tomtau tomtau merged commit 49976e2 into master Nov 29, 2022
tomtau pushed a commit that referenced this pull request Dec 1, 2022
…ed over IBC (#903)

Solution: Fixed denomID and tokenID splitting logic when denom has `ibc`.

* Fix lint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: query nft owner returns error when user has NFTs transferred over IBC
2 participants