Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: versiondb is not integrated #927

Merged
merged 7 commits into from
Mar 1, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Mar 1, 2023

Solution:

  • integrate versiondb streaming service
  • integrate changeset commands

versiondb is only enabled when built with rocksdb backend, we can change the build process in a separate PR.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- integrate versiondb streaming service
- integrate changeset commands
@yihuang yihuang requested a review from a team as a code owner March 1, 2023 09:18
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #927 (8925682) into master (8475d8d) will decrease coverage by 8.68%.
The diff coverage is 39.81%.

@@            Coverage Diff             @@
##           master     #927      +/-   ##
==========================================
- Coverage   31.31%   22.63%   -8.68%     
==========================================
  Files         116      120       +4     
  Lines       13449    13547      +98     
==========================================
- Hits         4212     3067    -1145     
- Misses       8231     9883    +1652     
+ Partials     1006      597     -409     
Flag Coverage Δ
integration_tests 20.90% <40.56%> (+0.13%) ⬆️
integration_tests_byzantine 8.03% <40.56%> (+0.22%) ⬆️
integration_tests_gov 8.29% <40.56%> (+0.22%) ⬆️
integration_tests_grpc 8.26% <40.56%> (+0.22%) ⬆️
integration_tests_ibc ?
integration_tests_ledger 8.26% <40.56%> (+0.22%) ⬆️
integration_tests_slow 8.26% <40.56%> (+0.22%) ⬆️
integration_tests_solomachine 8.03% <40.56%> (+0.22%) ⬆️
integration_tests_upgrade ?
unit_tests 5.89% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/versiondb.go 0.00% <0.00%> (ø)
app/versiondb_placeholder.go 0.00% <0.00%> (ø)
cmd/chain-maind/opendb/opendb_rocksdb.go 0.00% <0.00%> (ø)
app/app.go 81.21% <88.57%> (+3.65%) ⬆️
cmd/chain-maind/app/app.go 83.78% <100.00%> (+0.22%) ⬆️
cmd/chain-maind/app/versiondb.go 100.00% <100.00%> (ø)
x/nft-transfer/types/keys.go 0.00% <0.00%> (-100.00%) ⬇️
x/nft-transfer/keeper/msg_server.go 0.00% <0.00%> (-84.62%) ⬇️
x/nft-transfer/keeper/relay.go 0.00% <0.00%> (-75.00%) ⬇️
x/nft-transfer/keeper/packet.go 0.00% <0.00%> (-69.70%) ⬇️
... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yihuang yihuang added this pull request to the merge queue Mar 1, 2023
Merged via the queue into crypto-org-chain:master with commit e396992 Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants