Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: iavl-lazy-loading is not supported #942

Merged
merged 5 commits into from
Apr 26, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Apr 26, 2023

Solution:

  • update cosmos-sdk to v0.46.12

๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! ๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- update cosmos-sdk to v0.46.12
@yihuang yihuang requested a review from a team as a code owner April 26, 2023 08:10
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
@yihuang yihuang requested a review from mmsqe April 26, 2023 08:11
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #942 (6d89155) into master (45ba2ec) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #942      +/-   ##
==========================================
- Coverage   33.11%   33.04%   -0.07%     
==========================================
  Files         125      125              
  Lines       20133    20101      -32     
==========================================
- Hits         6667     6643      -24     
+ Misses      12382    12378       -4     
+ Partials     1084     1080       -4     
Flag Coverage ฮ”
integration_tests 20.39% <100.00%> (-0.09%) โฌ‡๏ธ
integration_tests_byzantine 9.52% <100.00%> (-0.11%) โฌ‡๏ธ
integration_tests_gov 9.74% <100.00%> (-0.11%) โฌ‡๏ธ
integration_tests_grpc 9.72% <100.00%> (-0.11%) โฌ‡๏ธ
integration_tests_ibc 24.57% <100.00%> (-0.09%) โฌ‡๏ธ
integration_tests_ledger 9.72% <100.00%> (-0.11%) โฌ‡๏ธ
integration_tests_slow 9.72% <100.00%> (-0.11%) โฌ‡๏ธ
integration_tests_solomachine 9.52% <100.00%> (-0.11%) โฌ‡๏ธ
integration_tests_upgrade 10.71% <100.00%> (-0.11%) โฌ‡๏ธ
unit_tests 10.87% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage ฮ”
cmd/chain-maind/app/app.go 83.20% <100.00%> (+0.91%) โฌ†๏ธ

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yihuang yihuang added this pull request to the merge queue Apr 26, 2023
Merged via the queue into crypto-org-chain:master with commit f016ec5 Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants