Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: local state-sync commands not integrated #975

Merged
merged 5 commits into from
May 29, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented May 26, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner May 26, 2023 03:41
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #975 (240342f) into master (7b9ba4d) will decrease coverage by 18.95%.
The diff coverage is n/a.

❗ Current head 240342f differs from pull request most recent head 9c66aa9. Consider uploading reports for the commit 9c66aa9 to get more accurate results

@@             Coverage Diff             @@
##           master     #975       +/-   ##
===========================================
- Coverage   29.90%   10.95%   -18.95%     
===========================================
  Files         124       60       -64     
  Lines       19974    15842     -4132     
===========================================
- Hits         5973     1736     -4237     
- Misses      12962    13966     +1004     
+ Partials     1039      140      -899     
Flag Coverage Δ
integration_tests ?
integration_tests_byzantine ?
integration_tests_gov ?
integration_tests_grpc ?
integration_tests_ibc ?
integration_tests_ledger ?
integration_tests_slow ?
integration_tests_solomachine ?
integration_tests_upgrade ?
unit_tests 10.95% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 112 files with indirect coverage changes

go.mod Outdated Show resolved Hide resolved
@yihuang yihuang added this pull request to the merge queue May 29, 2023
@yihuang yihuang removed this pull request from the merge queue due to a manual request May 29, 2023
go.mod Outdated Show resolved Hide resolved
@yihuang yihuang enabled auto-merge May 29, 2023 08:47
@yihuang yihuang added this pull request to the merge queue May 29, 2023
Merged via the queue into crypto-org-chain:master with commit a417387 May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants