-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSSC Solana updates #197
NSSC Solana updates #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to restructure the missing ownership.
Perhaps something like:
Pseudo code
instruction pay_escrow(accounts)
if accounts.state.escrow_state == complete {
tokens.transfer(escrow_vault, accounts.state.escrow_receiver, accounts.state.escrow_amount);
}
The working principle is some sort of escrow contract with a state and vault account.
Because of the missing ownership check on the passed state account, it is possible to make the contract believe the escrow is complete and transfer funds to the receiver.
From our perspective, this is ready for review, @montyly. |
Several language fixes, as well as bug fixes to the owner and signer check examples.