Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSSC Solana updates #197

Merged
merged 8 commits into from
Feb 7, 2023
Merged

NSSC Solana updates #197

merged 8 commits into from
Feb 7, 2023

Conversation

smoelius
Copy link
Member

@smoelius smoelius commented Jan 20, 2023

Several language fixes, as well as bug fixes to the owner and signer check examples.

@smoelius smoelius requested a review from nop4e71 January 20, 2023 15:18
@smoelius smoelius marked this pull request as draft January 20, 2023 15:18
Copy link
Contributor

@nop4e71 nop4e71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to restructure the missing ownership.
Perhaps something like:

Pseudo code
instruction pay_escrow(accounts)
  if accounts.state.escrow_state == complete {
    tokens.transfer(escrow_vault, accounts.state.escrow_receiver, accounts.state.escrow_amount); 
  }

The working principle is some sort of escrow contract with a state and vault account.
Because of the missing ownership check on the passed state account, it is possible to make the contract believe the escrow is complete and transfer funds to the receiver.

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2023

CLA assistant check
All committers have signed the CLA.

@smoelius smoelius marked this pull request as ready for review February 7, 2023 12:21
@smoelius
Copy link
Member Author

smoelius commented Feb 7, 2023

From our perspective, this is ready for review, @montyly.

@montyly montyly merged commit c039384 into master Feb 7, 2023
@montyly montyly deleted the nssc-solana-updates branch February 7, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants