Fix W256 values parsing from config #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcz
force-pushed
the
fix-W256-parsing
branch
from
48f298c
to
9e305ec
Compare
arcz
force-pushed
the
fix-W256-parsing
branch
from
9e305ec
to
ede63f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix any issues we have with parsing larger values than would fix into the target type. #792
An error is shown when the values overflow, in contrast to the already existing PR that would silently accept those values #792. I believe it is better to let the user know that the value is wrong. I also adjusted some types, so they better describe the values.