Skip to content

Commit

Permalink
Only init DefaultTracerProvider if tracing is enabled
Browse files Browse the repository at this point in the history
Stay with NOOP provider otherwise
  • Loading branch information
rhafer committed Jun 16, 2022
1 parent f7b1b5f commit 9a5e50c
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion cmd/revad/runtime/runtime.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,9 @@ func initServers(mainConf map[string]interface{}, log *zerolog.Logger, tp trace.
}

func initTracing(conf *coreConf) trace.TracerProvider {
rtrace.InitDefaultTracerProvider(conf.TracingCollector, conf.TracingEndpoint)
if conf.TracingEnabled {
rtrace.InitDefaultTracerProvider(conf.TracingCollector, conf.TracingEndpoint)
}
return rtrace.GetTracerProvider(conf.TracingEnabled, conf.TracingCollector, conf.TracingEndpoint, conf.TracingServiceName)
}

Expand Down

0 comments on commit 9a5e50c

Please sign in to comment.