Skip to content

Commit

Permalink
fix create space error message (#2452)
Browse files Browse the repository at this point in the history
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
  • Loading branch information
butonic committed Jan 18, 2022
1 parent d41f7c8 commit 9dd1f75
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions changelog/unreleased/fix-create-space-error-msg.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: fix create space error message

Create space no longer errors with list spaces error messages.

https://github.com/cs3org/reva/pull/2452
4 changes: 2 additions & 2 deletions internal/grpc/services/storageprovider/storageprovider.go
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ func (s *service) CreateStorageSpace(ctx context.Context, req *provider.CreateSt
var st *rpc.Status
switch err.(type) {
case errtypes.IsNotFound:
st = status.NewNotFound(ctx, "not found when listing spaces")
st = status.NewNotFound(ctx, "not found when creating space")
case errtypes.PermissionDenied:
st = status.NewPermissionDenied(ctx, err, "permission denied")
case errtypes.NotSupported:
Expand All @@ -506,7 +506,7 @@ func (s *service) CreateStorageSpace(ctx context.Context, req *provider.CreateSt
case errtypes.AlreadyExists:
st = status.NewAlreadyExists(ctx, err, "already exists")
default:
st = status.NewInternal(ctx, "error listing spaces")
st = status.NewInternal(ctx, "error creating space")
appctx.GetLogger(ctx).
Error().
Err(err).
Expand Down

0 comments on commit 9dd1f75

Please sign in to comment.