handle sending all permissions when creating public links #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
requested review from
glpatcern,
ishank011,
labkode and
a team
as code owners
C0rby
suggested changes
Dec 7, 2021
internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/public.go
Outdated
Show resolved
Hide resolved
refs
approved these changes
Dec 7, 2021
internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/public.go
Outdated
Show resolved
Hide resolved
internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/public.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
handle-public-link-permissions-all
branch
from
da004d7
to
e7bee4a
Compare
C0rby
approved these changes
Dec 8, 2021
22 tasks
26 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For backwards compatability we now reduce permissions to readonly when a create public link carries all permissions.
Adresses owncloud/ocis#1269 (comment)