fix-archiver #2348
Merged
fix-archiver #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
requested review from
glpatcern,
ishank011,
labkode and
a team
as code owners
|
Can we add an api test? |
|
@micbar not right now, I am tryding to make the ocis PR green ... I tried fo 30min to write api tists for this. I'll have to mock even an http client and pass that in ... something I can do while waiting for the CI ... |
kobergj
approved these changes
Dec 9, 2021
|
@butonic are the tests in an other PR? |
|
I discovered this in the ocis test suite. yes it is easy to cover in reva with a unit test, which I will write during ci runs ... but ... as it turns out ... far more is broken ... need to dig and will try to cover this as I go. |
22 tasks
26 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The archiver can now handle the spaces protocol. The ocis testsuite caught this one in https://drone.owncloud.com/owncloud/ocis/8266/21/6