reduce logging output #2353
Merged
reduce logging output #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Similarly, should both the services and the gateway log stuff or only one of both? If the latter who should log? I'd say the service itself would make sense. |
|
I added error logging to the storage provider. It probably would make sense to have more logging in other places too but I propose to add those when we are working at those places. |
|
I find this approach better rather than having a wall of text. Adding logging when needed (if needed) is more beneficial 👍 |
C0rby
force-pushed
the
reduce-logging
branch
from
fc69beb
to
8a9f44c
Compare
|
This pull request introduces 25 alerts when merging 8a9f44c into e0529be - view on LGTM.com new alerts:
|
C0rby
force-pushed
the
reduce-logging
branch
from
8a9f44c
to
847eb39
Compare
C0rby
requested review from
glpatcern,
ishank011,
labkode,
wkloucek and
a team
as code owners
|
There are more things that can be done but I'm going to leave it at that to not make this PR any longer. |
refs
approved these changes
Dec 14, 2021
rhafer
approved these changes
Dec 14, 2021
kobergj
approved these changes
Dec 14, 2021
26 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced log output. Some errors or warnings were logged multiple times or even unnecesarily.
Now, there are probably a lot of places where logging is missing but these can be added when we touch those spots again.