Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use space description on creation #2533

Merged
merged 4 commits into from
Feb 14, 2022
Merged

Conversation

micbar
Copy link
Member

@micbar micbar commented Feb 13, 2022

Description

  1. Make it possible to send an opaque "description" value in the CreateStorageSpaces Request.

  2. Fixed a bug in the sharing roles. CoOnwners are now Managers.

@cs3org cs3org deleted a comment from update-docs bot Feb 13, 2022
@micbar micbar requested review from butonic and C0rby February 14, 2022 07:36
@micbar micbar marked this pull request as ready for review February 14, 2022 07:36
@butonic
Copy link
Contributor

butonic commented Feb 14, 2022

well, IMO we should rename Coowners, as ... they no longer exist, right?

@micbar
Copy link
Member Author

micbar commented Feb 14, 2022

ok, but for me not in the scope of this PR

That would make merging master into edge more difficult.

@butonic butonic merged commit 5832a9b into cs3org:edge Feb 14, 2022
Copy link
Contributor

@dragotin dragotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments...

pkg/storage/utils/decomposedfs/spaces.go Show resolved Hide resolved
pkg/storage/utils/decomposedfs/spaces.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants