Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locks mutexed #2582

Merged
merged 4 commits into from
Feb 24, 2022
Merged

Locks mutexed #2582

merged 4 commits into from
Feb 24, 2022

Conversation

dragotin
Copy link
Contributor

There must be only one Flock struct per lock file. If that
is existing, no other routine or process may get a lock.

@update-docs
Copy link

update-docs bot commented Feb 23, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dragotin dragotin requested review from glpatcern and a team as code owners February 23, 2022 09:42
@glpatcern glpatcern mentioned this pull request Feb 23, 2022
Merged
glpatcern
glpatcern approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though final word is for @butonic I guess. Will see if we can use (some of) this also in the EOS storage implementation, #2444

C0rby
C0rby suggested changes Feb 23, 2022
View reviewed changes
pkg/storage/utils/filelocks/filelocks.go Outdated Show resolved Hide resolved
pkg/storage/utils/filelocks/filelocks.go Outdated Show resolved Hide resolved
@dragotin dragotin requested a review from C0rby February 24, 2022 10:26
C0rby
C0rby approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

pkg/storage/utils/filelocks/filelocks.go Outdated Show resolved Hide resolved
@dragotin
Keep the lock structs in a local map, protected by a mutex.
c1c9383 
There must be only one Flock struct per lock file. If that
is existing, no other routine or process may get a lock.
@dragotin
Add Changelog
b1112e5
@dragotin
Use sync.Map for a thread save local storage of locks.
0628ef1 
Some more cleanups.
@dragotin
Remove unused empty init() function.
5500024
@micbar micbar merged commit d4ffaf3 into edge Feb 24, 2022
@C0rby C0rby deleted the locksmutexed branch February 24, 2022 11:43
@micbar micbar mentioned this pull request Feb 24, 2022
Closed
@micbar micbar mentioned this pull request Mar 3, 2022
Closed
26 tasks
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@C0rby C0rby C0rby approved these changes

@glpatcern glpatcern glpatcern approved these changes

@butonic butonic Awaiting requested review from butonic

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dragotin @micbar @C0rby @glpatcern