Add metadata storage and indexer #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduffeck
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
kobergj
requested changes
Feb 23, 2022
C0rby
reviewed
Feb 23, 2022
Comment on lines
89
to
93
| var matches = make([]string, 0) | ||
| paths, err := idx.storage.ReadDir(context.Background(), path.Join("/", idx.indexRootDir, v)) | ||
|
|
||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| for _, p := range paths { | ||
| matches = append(matches, path.Base(p)) | ||
| } |
There was a problem hiding this comment.
Suggested change
| var matches = make([]string, 0) | |
| paths, err := idx.storage.ReadDir(context.Background(), path.Join("/", idx.indexRootDir, v)) | |
| if err != nil { | |
| return nil, err | |
| } | |
| for _, p := range paths { | |
| matches = append(matches, path.Base(p)) | |
| } | |
| paths, err := idx.storage.ReadDir(context.Background(), path.Join("/", idx.indexRootDir, v)) | |
| if err != nil { | |
| return nil, err | |
| } | |
| matches = make([]string, 0, len(paths)) | |
| for _, p := range paths { | |
| matches = append(matches, path.Base(p)) | |
| } |
pkg/storage/utils/indexer/indexer.go
Outdated
| } | ||
| } | ||
| default: | ||
| return fmt.Errorf("operator not supported") |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("operator not supported") | |
| return errors.New("operator not supported") |
pkg/storage/utils/metadata/disk.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| entries := []string{} |
There was a problem hiding this comment.
Suggested change
| entries := []string{} | |
| entries := make([]string, 0, len(infos)) |
aduffeck
force-pushed
the
add-metadata-storage-and-indexer
branch
from
9234d98
to
915bf71
Compare
Spoiler: It doesn't work
That can be used in cases where it's not a single field holding the information, e.g. in case of polymorphism.
aduffeck
force-pushed
the
add-metadata-storage-and-indexer
branch
from
d349276
to
ce45140
Compare
26 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the metadata storage layer and the indexer from ocis-pkg. The indexer has also been extended to allow for indexing nested fields and supporting index functions that are necessary for indexing polymorphic fields.