Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decomposed fs: return reference to parent #2691

Merged
merged 4 commits into from
Mar 31, 2022
Merged

decomposed fs: return reference to parent #2691

merged 4 commits into from
Mar 31, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Mar 29, 2022

Description

We've implemented the changes from cs3org/cs3apis#167 in the DecomposedFS, so that a stat on a resource always includes a reference to the parent of the resource.

Related issues

fixes owncloud/ocis#3409
related to:

@update-docs
Copy link

update-docs bot commented Mar 29, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek changed the title [decomposed fs] return parent on stat requests decomposed fs: return reference to parent Mar 29, 2022
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A priori this commit: 4f44ffc is not needed if you first merge Reva master. And it will create conflicts once you merge master...

@wkloucek
Copy link
Contributor Author

A priori this commit: 4f44ffc is not needed if you first merge Reva master. And it will create conflicts once you merge master...

cs3org/go-cs3apis@80eca45 is not yet implemented in master. A merge of master to edge would needed to be done in a separate PR, since this too big for the scope of this PR

@glpatcern
Copy link
Member

Yes, surely the master merge should be done in a separate PR. Maybe worth doing it beforehand though, or if later then you know you'll have to amend that commit to resolve the inevitable conflict.

@wkloucek wkloucek marked this pull request as ready for review March 29, 2022 13:22
@wkloucek wkloucek requested review from a team, labkode and ishank011 as code owners March 29, 2022 13:22
@wkloucek wkloucek requested review from butonic, kobergj and C0rby and removed request for a team, labkode and ishank011 March 29, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants