Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil node on err #3534

Closed
wants to merge 2 commits into from
Closed

Fix nil node on err #3534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc230cc
fix panic when returning an error
butonic Dec 8, 2022
b9ab105
add changelog
butonic Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/unreleased/fix-nil-node-on-error.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Bugfix: prevent panic in decomposed node when returning an error

https://github.com/cs3org/reva/pull/3534
5 changes: 4 additions & 1 deletion pkg/storage/utils/decomposedfs/node/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,10 @@ func ReadNode(ctx context.Context, lu PathLookup, spaceID, nodeID string, canLis

// append back revision to nodeid, even when returning a not existing node
defer func() {
n.ID += revisionSuffix
// when returning errors n is nil
if n != nil {
n.ID += revisionSuffix
}
}()

nodePath := n.InternalPath()
Expand Down