More Async Upload Fixes #3571
Merged
More Async Upload Fixes #3571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
kobergj
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
kobergj
force-pushed
the
AsyncUploadFixes
branch
from
7a2ea06
to
8ea0228
Compare
micbar
reviewed
Dec 28, 2022
| @@ -263,15 +263,13 @@ func (upload *Upload) FinishUpload(_ context.Context) error { | |||
| } | |||
| } | |||
|
|
|||
| if upload.async { | |||
| // handle postprocessing asynchronously but inform there is something in progress | |||
| return upload.tp.Propagate(upload.Ctx, n, upload.sizeDiff) | |||
There was a problem hiding this comment.
not needed anymore? where do we propagate now?
There was a problem hiding this comment.
We still propagate. I just switched the code parts so we need to call to upload.tp.Propagate only once
micbar
approved these changes
Dec 29, 2022
This was referenced Jan 2, 2023
Closed
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes owncloud/ocis#5278 and owncloud/ocis#5279