[WIP] Use rename in blob upload #3676
Conversation
Otherwise fall back to file copy
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
|
||
| // ensure parent path exists | ||
| if err := os.MkdirAll(filepath.Dir(bs.path(node)), 0700); err != nil { | ||
| return errors.Wrap(err, "Decomposedfs: oCIS blobstore: error creating parent folders for blob") | ||
| } | ||
|
|
||
| f, err := os.OpenFile(bs.path(node), os.O_CREATE|os.O_WRONLY, 0700) | ||
| // check that destination is not a directory, that makes Rename fail |
There was a problem hiding this comment.
Did you actually run into the problem that the blob already exists as a directory? That would be somewhat worrisome because the blobstore storage should be controlled by the blobstore itself and it only creates files for the blobs, with the name being derived from the blobid of the node.
There was a problem hiding this comment.
Otherwise I think I would rather omit the special handling for the non-expected case, knowing that the code writing the blob will fail anyway when trying to write to a directory.
There was a problem hiding this comment.
Ok, removed the directory check.
|
closing in favor of #3739 |
Use rename instead of copy data again for the cost of an less clean interface of BlobStore. @aduffeck