change language code validation #3755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbar
requested review from
labkode,
ishank011,
wkloucek,
glpatcern and
a team
as code owners
|
@glpatcern something worth cherry-picking to master? |
|
Yep, looked at it already 👀 and no, the way we pass the language in master is actually different as we read it from the configuration, and we're assuming the config is correct (i.e. not having the "subtag"). We use |
kobergj
approved these changes
Mar 28, 2023
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: Fix app provider language validation
This changes the validation to only look at the first part (tag) of the language code and ignore the second part (sub-tag).