Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error during mkcol #3834

Merged
merged 3 commits into from
May 2, 2023
Merged

fix error during mkcol #3834

merged 3 commits into from
May 2, 2023

Conversation

micbar
Copy link
Member

@micbar micbar commented Apr 29, 2023

Description

We need to return 409 Conflict when one or more path elements during an MKCOL do not exist.

Fixes: owncloud/ocis#6136

@micbar
Copy link
Member Author

micbar commented Apr 29, 2023

@dragotin This is a fix to enable the usage of rclone

@glpatcern
Copy link
Member

@redblom do we need this in master or do we already have this behaviour?

@redblom
Copy link
Contributor

redblom commented May 1, 2023

@micbar @glpatcern : I can confirm that master returns 409 Conflict and rclone behaves as expected, it can create a complete new path.

@micbar
Copy link
Member Author

micbar commented May 2, 2023

@micbar @glpatcern : I can confirm that master returns 409 Conflict and rclone behaves as expected, it can create a complete new path.

@redblom Can you check if this is also the case for non-existing sub-sub directories?

Copy link

@dragonchaser dragonchaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@redblom
Copy link
Contributor

redblom commented May 2, 2023

@redblom Can you check if this is also the case for non-existing sub-sub directories?

@micbar Yes, also with sub/sub/.. directories, the response is always 409 Conflict (message: Parent node does not exist)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants