Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shapely>=2.0 is incompatible with pymt #164

Open
mdpiper opened this issue Feb 3, 2023 · 2 comments
Open

shapely>=2.0 is incompatible with pymt #164

mdpiper opened this issue Feb 3, 2023 · 2 comments

Comments

@mdpiper
Copy link
Member

mdpiper commented Feb 3, 2023

shapely had a major release recently, and it looks like the geometry types changed, which causes pymt to fail:

 ______________________ ERROR collecting pymt/grids/map.py ______________________
Traceback (most recent call last):
  File "/Users/runner/work/pymt/pymt/pymt/grids/map.py", line 49, in <module>
    from shapely.geometry import Point, asLineString, asPoint, asPolygon
ImportError: cannot import name 'asLineString' from 'shapely.geometry' (/usr/local/miniconda/envs/test/lib/python3.8/site-packages/shapely/geometry/__init__.py)
@mdpiper
Copy link
Member Author

mdpiper commented Feb 3, 2023

Requiring shapely<2 works.

The solution might be as simple as changing the asLineString type to LineString.

@mdpiper
Copy link
Member Author

mdpiper commented Oct 2, 2024

This is blocking building pymt on Python 3.12.

mdpiper added a commit to mdpiper/pymt that referenced this issue Oct 2, 2024
The subsequent call to `mamba install` updates *shapely* to 2.0,
which breaks the <1.9 requirement from csdms#164.
mcflugen pushed a commit that referenced this issue Oct 3, 2024
The subsequent call to `mamba install` updates *shapely* to 2.0,
which breaks the <1.9 requirement from #164.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant