-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cue fmt --simplify removes ellipsis comments #3198
Labels
Comments
NoamTD
changed the title
cue fmt --simplify removes comment above elipsis
cue fmt --simplify removes ellipsis comments
Jun 4, 2024
cueckoo
pushed a commit
that referenced
this issue
Jun 6, 2024
Whe simplification is enabled, the current implementation prints a "dummy" ellipsis during formatting, instead of the original ellipsis. This means that comments associated with the original ellipsis are not printed in the formatted CUE. To fix this, we associate the original comments with the dummy ellipsis so they won't get lost. Fixes #3198. Signed-off-by: Noam Dolovich <noam.tzvi.dolovich@gmail.com> Change-Id: Ibebbd97ac768de7a2c0d9855c9ec6c7a497435c8
cueckoo
pushed a commit
that referenced
this issue
Jun 7, 2024
This adds some tests for handling of comments associated with ellipseses when running `cue fmt -s`. Updates #3198. Signed-off-by: Noam Dolovich <noam.tzvi.dolovich@gmail.com> Change-Id: I24d8adaadcfe2d14b3231ac057252d582f0b9624
cueckoo
pushed a commit
that referenced
this issue
Jun 7, 2024
Whe simplification is enabled, the current implementation prints a "dummy" ellipsis during formatting, instead of the original ellipsis. This means that comments associated with the original ellipsis are not printed in the formatted CUE. To fix this, we associate the original comments with the dummy ellipsis so they won't get lost. Fixes #3198. Signed-off-by: Noam Dolovich <noam.tzvi.dolovich@gmail.com> Change-Id: I276e573db8d7b4e6b69db25a164be7211378d486
cueckoo
pushed a commit
that referenced
this issue
Jun 7, 2024
Whe simplification is enabled, the current implementation prints a "dummy" ellipsis during formatting, instead of the original ellipsis. This means that comments associated with the original ellipsis are not printed in the formatted CUE. To fix this, we associate the original comments with the dummy ellipsis so they won't get lost. Fixes #3198. Signed-off-by: Noam Dolovich <noam.tzvi.dolovich@gmail.com> Change-Id: Ibebbd97ac768de7a2c0d9855c9ec6c7a497435c8
cueckoo
pushed a commit
that referenced
this issue
Jun 7, 2024
When simplification is enabled, the current implementation prints a "dummy" ellipsis during formatting, instead of the original ellipsis. This means that comments associated with the original ellipsis are not printed in the formatted CUE. To fix this, we associate the original comments with the dummy ellipsis so they won't get lost. Fixes #3198. Signed-off-by: Noam Dolovich <noam.tzvi.dolovich@gmail.com> Change-Id: Ibebbd97ac768de7a2c0d9855c9ec6c7a497435c8
cueckoo
pushed a commit
that referenced
this issue
Jun 7, 2024
This adds some tests for handling of comments associated with ellipseses when running `cue fmt -s`. Updates #3198. Signed-off-by: Noam Dolovich <noam.tzvi.dolovich@gmail.com> Change-Id: I24d8adaadcfe2d14b3231ac057252d582f0b9624 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1195919 Reviewed-by: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of CUE are you using (
cue version
)?Does this issue reproduce with the latest stable release?
yes
What did you do?
I ran the below test:
What did you expect to see?
a passing test
What did you see instead?
a failing test:
The text was updated successfully, but these errors were encountered: