[CDP-1506] Fix version handling #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabland
approved these changes
Jul 8, 2024
ebobby
force-pushed
the
CDP-1506-fix-version-handling
branch
2 times, most recently
from
925a732
to
b15ac06
Compare
sydneycollins-cio
approved these changes
Jul 8, 2024
ebobby
force-pushed
the
CDP-1506-fix-version-handling
branch
from
b15ac06
to
2036071
Compare
Nuno did all the work.
ebobby
force-pushed
the
CDP-1506-fix-version-handling
branch
from
2036071
to
73a7bcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an inconsistency with the version the library identifies as, and the actual package version. That was because the version was bumped when publishing but after building.
Now we bump first and then build/publish.
CDP-1506