chore: sample app fixes #136
Conversation
| @@ -40,6 +43,7 @@ android { | |||
| targetSdkVersion 33 | |||
| versionCode 1 | |||
| versionName "1.0" | |||
| multiDexEnabled true | |||
There was a problem hiding this comment.
I think that this increases build times when it's enabled so just calling it out to make sure this is required and it wasn't automatically added or you forgot to remove it. If you added it intentionally, no problem.
There was a problem hiding this comment.
Correct. This too was added only for flutter_local_notifications gradle setup.
|
|
||
| extension LocationExtensions on GoRouter { | ||
| // Get location of current route | ||
| // This is a workaround to get the current location as location property |
There was a problem hiding this comment.
Since this is labeled as a workaround, it makes me wonder if this is a short-term solution? To make our sample app an up-to-date reference for customers, should we replace this with recommended best practice code in the future?
There was a problem hiding this comment.
Agreed. I'm not expert with GoRouter so not fully sure about best practices for it at the moment. But yes, we can put at a ticket to simplify and improve this for customers. Sample apps project could be the best time to handle this? 🤔
| ndkVersion flutter.ndkVersion | ||
|
|
||
| compileOptions { | ||
| // Flag to enable support for the new language APIs | ||
| coreLibraryDesugaringEnabled true |
There was a problem hiding this comment.
interesting, what new language API are we introducing?
There was a problem hiding this comment.
This is required by flutter_local_notifications gradle setup.
part of MBL-420
Changes
build.gradleas required byflutter_local_notifications