Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wrap unit calls with boolean result #142

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

mrehan27
Copy link
Contributor

fixes: #141
part of MBL-494

Changes

  • Return boolean value for unit calls as native calls must return some value

@mrehan27 mrehan27 self-assigned this Aug 30, 2024
Copy link

github-actions bot commented Aug 30, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • amiapp_flutter: 142.1.0 (28750332)

Copy link
Collaborator

@Shahroz16 Shahroz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, can we please fix the lining issues too?

@mrehan27 mrehan27 merged commit 1635acf into main Sep 4, 2024
5 of 6 checks passed
@mrehan27 mrehan27 deleted the rehan/mbl-494-unit-fix branch September 4, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button with dismiss behavior do not close in app message on some Android devices.
2 participants