Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate libldap2-dev in Dockerfile #1852

Closed
smokedsalmonbagel opened this issue Jul 3, 2020 · 0 comments
Closed

Duplicate libldap2-dev in Dockerfile #1852

smokedsalmonbagel opened this issue Jul 3, 2020 · 0 comments
Assignees
@azhavoro
Labels
Easy to fix The issue is easy to fix and probably it will be release in a next minor release

Comments

@smokedsalmonbagel
Copy link

My actions before raising this issue

Expected Behaviour

I think this should only be here once.

Current Behaviour

It is here twice.
https://github.com/opencv/cvat/blob/18f6b2f95d0bcd0a491ad3f7a892fabb734f7b00/Dockerfile#L46
https://github.com/opencv/cvat/blob/18f6b2f95d0bcd0a491ad3f7a892fabb734f7b00/Dockerfile#L43

Possible Solution

Remove one line. Or maybe 2 are needed?

Context

I noticed this when trying to solve another issue.

Your Environment

  • Git hash commit (git log -1): 18f6b2f
  • Docker version docker version (e.g. Docker 17.0.05): 19.03.12
  • Are you using Docker Swarm or Kubernetes? no
  • Operating System and version (e.g. Linux, Windows, MacOS): Ubuntu 18.04.4 LTS
  • Code example or link to GitHub repo or gist to reproduce problem:
  • Other diagnostic information / logs:

Next steps

You may join our Gitter channel for community support.
@azhavoro azhavoro self-assigned this Jul 6, 2020
@azhavoro azhavoro added Easy to fix The issue is easy to fix and probably it will be release in a next minor release good first issue labels Jul 6, 2020
lravindr added a commit to lravindr/cvat that referenced this issue Jul 17, 2020
@lravindr
Remove redundant installation of libldap2-dev
dc6da7f 
Removed the redundant installation of libldap2-dev library in the Dockerfile. This is fixing for cvat-ai#1852.
@lravindr lravindr mentioned this issue Jul 17, 2020
Merged
4 tasks
nmanovic pushed a commit that referenced this issue Jul 17, 2020
@lravindr
Remove redundant installation of libldap2-dev (#1910)
5b9a1dc 
Removed the redundant installation of libldap2-dev library in the Dockerfile. This is fixing for #1852.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azhavoro azhavoro

Labels
Easy to fix The issue is easy to fix and probably it will be release in a next minor release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smokedsalmonbagel @nmanovic @azhavoro