Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datumaro] Allow any annotations file name in coco extractor #1650

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

zhiltsov-max
Copy link
Contributor

Motivation and context

If we add a file directly by its path, there is no reason to disallow arbitrary file names. The name should be used to recognize subset, but if it can't be done we can just use the default subset. This does not happen in official COCO format, but for custom annotation this improves quality of life.

How has this been tested?

Manual test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@zhiltsov-max zhiltsov-max changed the title Allow any annotations file name in coco extractor [Datumaro] Allow any annotations file name in coco extractor Jun 5, 2020
@zhiltsov-max zhiltsov-max changed the title [Datumaro] Allow any annotations file name in coco extractor [WIP] [Datumaro] Allow any annotations file name in coco extractor Jun 5, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5493

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 65.643%

Files with Coverage Reduction New Missed Lines %
datumaro/datumaro/components/extractor.py 1 90.59%
cvat/apps/engine/media_extractors.py 8 75.29%
Totals Coverage Status
Change from base Build 5489: -0.04%
Covered Lines: 10887
Relevant Lines: 16181

💛 - Coveralls

@nmanovic nmanovic changed the title [WIP] [Datumaro] Allow any annotations file name in coco extractor [Datumaro] Allow any annotations file name in coco extractor Jun 16, 2020
@nmanovic nmanovic merged commit 47470b8 into develop Jun 16, 2020
@bsekachev bsekachev deleted the zm/allow-any-coco-filename branch June 17, 2020 15:42
frndmg pushed a commit to signatrix/cvat that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants