[Datumaro] Support relative paths #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues
======
- Added 1
Complexity increasing per file
==============================
- datumaro/tests/test_yolo_format.py 2
Complexity decreasing per file
==============================
+ datumaro/datumaro/plugins/voc_format/converter.py -2
+ datumaro/datumaro/plugins/tf_detection_api_format/extractor.py -1
+ datumaro/datumaro/plugins/yolo_format/converter.py -1
See the complete overview on Codacy |
nmanovic
reviewed
Jun 15, 2020
| # NOTE: when path is like [data/]<subset_obj>/<image_name> | ||
| # drop everything but <image name> | ||
| # <image name> can be <a/b/c/filename.ext>, so no just basename() | ||
| path = osp.join(*parts[1:]) |
There was a problem hiding this comment.
Pull Request Test Coverage Report for Build 5768
💛 - Coveralls |
azhavoro
approved these changes
Jun 16, 2020
7 tasks
nmanovic
reviewed
Jun 17, 2020
| save_image(osp.join(save_dir, item.id + '.jpg'), |
There was a problem hiding this comment.
What if the original images were PNG or any other format? Don't you have all these issues just because item.id doesn't the the original extension?
There was a problem hiding this comment.
all these issues
Which ones?
- Relative paths? They have no relation to extensions and are not used in any dataset format.
- Appending an extension in converters? Maybe, but the extension, as well as fill image path, is available in
item.image.path. And an option to copy original images files instead of recoding them is a matter of further PRs, as well as keeping the original extension, where applicable.
Meanwhile, we have to add an extension if we have a video frame, or if we have only frame data and no image info.
nmanovic
reviewed
Jun 17, 2020
| @@ -311,7 +311,9 @@ def __call__(self, extractor, save_dir): | |||
|
|
|||
| if self._save_images: | |||
| if item.has_image and item.image.has_data: | |||
| self._save_image(item, index=frame_id) | |||
| save_image(osp.join(self._images_dir, | |||
There was a problem hiding this comment.
again. We have a limitation here.
nmanovic
approved these changes
Jun 17, 2020
frndmg
pushed a commit
to signatrix/cvat
that referenced
this pull request
Aug 5, 2020
* Support relative image paths in Datumaro * Update bindings * Fix merge * linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Preparation for #1463
DatasetItem.id's now represent a relative path (without an extension)DatasetItem.image.pathnow contains a real or supposed local image pathHow has this been tested?
Unit tests.
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.