Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datumaro] Convert command #1837

Merged
merged 5 commits into from
Jul 11, 2020
Merged

[Datumaro] Convert command #1837

merged 5 commits into from
Jul 11, 2020

Conversation

zhiltsov-max
Copy link
Contributor

Motivation and context

Added a shortcut convert command to convert datasets. This is supposed to simplify tool usage.

How has this been tested?

Manual test

How to test:

datum convert -h
datum convert -i src/path -f dst_format [-if src_format]

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@zhiltsov-max zhiltsov-max changed the title Zm/convert command [Datumaro] Convert command Jul 2, 2020
@coveralls
Copy link

coveralls commented Jul 2, 2020

Pull Request Test Coverage Report for Build 6373

  • 10 of 72 (13.89%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 64.989%

Changes Missing Coverage Covered Lines Changed/Added Lines %
datumaro/datumaro/cli/commands/convert.py 10 72 13.89%
Files with Coverage Reduction New Missed Lines %
datumaro/datumaro/components/extractor.py 1 91.01%
Totals Coverage Status
Change from base Build 6362: -0.2%
Covered Lines: 11072
Relevant Lines: 16628

💛 - Coveralls

azhavoro
azhavoro previously approved these changes Jul 10, 2020
Copy link
Contributor

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- datumaro/datumaro/cli/commands/convert.py  16
         

See the complete overview on Codacy

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit 575c93f into develop Jul 11, 2020
@nmanovic nmanovic deleted the zm/convert-command branch July 11, 2020 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants