Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow saving empty XMLs in VOC #1883

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Conversation

zhiltsov-max
Copy link
Contributor

Motivation and context

Annotation-less XMLs were not saved, while they should.

How has this been tested?

Manual test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Copy link
Contributor

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
           

Complexity increasing per file
==============================
- datumaro/datumaro/plugins/voc_format/converter.py  2
         

See the complete overview on Codacy

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6388

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 65.191%

Files with Coverage Reduction New Missed Lines %
cvat/apps/engine/media_extractors.py 2 77.06%
datumaro/datumaro/plugins/voc_format/converter.py 2 88.67%
Totals Coverage Status
Change from base Build 6382: -0.02%
Covered Lines: 11059
Relevant Lines: 16556

💛 - Coveralls

@nmanovic nmanovic merged commit 78f1893 into develop Jul 10, 2020
@nmanovic nmanovic deleted the zm/export-empty-voc-detections branch July 10, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants