Sort files and folders in the share path #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bsekachev I am not sure if I should update this change as a patch or a minor version. I am also not sure if should mention this small change in the documentation. Do you have input regarding this? |
Pull Request Test Coverage Report for Build 6655
💛 - Coveralls |
|
@BenjiSchlotter Hi, please |
bsekachev
reviewed
Jul 29, 2020
| @@ -129,6 +129,8 @@ export default class FileManager extends React.PureComponent<Props, State> { | |||
|
|
|||
| private renderShareSelector(): JSX.Element { | |||
| function renderTreeNodes(data: TreeNodeNormal[]): JSX.Element[] { | |||
| // sort alphabetically | |||
| data.sort((a, b) => (a.key > b.key) ? 1 : -1) | |||
There was a problem hiding this comment.
Static linter shows the issue here: Arrow function used ambiguously with a conditional expression.eslintno-confusing-arrow
Maybe use such kind of sorting?
data.sort((a: TreeNodeNormal, b: TreeNodeNormal): number => a.key.localeCompare(b.key));
There was a problem hiding this comment.
I changed it to your suggestion.
bsekachev
approved these changes
Jul 29, 2020
|
@BenjiSchlotter Thanks again for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Currently the files and folders lists under share path in the task creation view are not sorted. This can be annoying to work with when creating tasks manually for a lot of folders.
How has this been tested?
Added a path as share path with a lot of sub folders and checked manually that those folders are sorted alphabetically.
Checklist
developbranch- [ ] I have added tests to cover my changescvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
- [ ] I have updated the license header for each file (see an example below)