Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload big xml files for tasks #199

Merged
merged 13 commits into from
Nov 24, 2018
Merged

Conversation

nmanovic
Copy link
Contributor

Fix #123.

  • I don't like the solution. It isn't good split annotations on several parts and submit one by one. Need to find a better solution.
  • Add good profiler: Silk
  • Optimize a little bit save_job

@nmanovic nmanovic changed the title [WIP] Fix upload big xml files for tasks Fix upload big xml files for tasks Nov 20, 2018
@nmanovic
Copy link
Contributor Author

@azhavoro, @bsekachev,

Please review. It seems to split on chunks isn't a bad idea. I implemented the approach only when we upload annotations for a task. In general need to send "chunks" when we upload data for a job and when we save annotations for a job. In the latest case need to be sure that we update internal state correctly.

@nmanovic nmanovic changed the title Fix upload big xml files for tasks [WIP] Fix upload big xml files for tasks Nov 20, 2018
@nmanovic
Copy link
Contributor Author

@bsekachev , @azhavoro Found several problems:

  • Dump file with several jobs have the same IDs
  • If upload annotations and download them IDs will be -1

@nmanovic nmanovic changed the title [WIP] Fix upload big xml files for tasks Fix upload big xml files for tasks Nov 21, 2018
cvat/apps/dashboard/static/dashboard/js/dashboard.js Outdated Show resolved Hide resolved
},
error: function(response) {
let message = 'Annotation uploading errors was occured. ' + response.responseText;
let message = 'Annotation uploading errors was occurred: ' +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no data uploading. Clean up only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

cvat/apps/dashboard/static/dashboard/js/dashboard.js Outdated Show resolved Hide resolved
cvat/apps/dashboard/static/dashboard/js/dashboard.js Outdated Show resolved Hide resolved
@nmanovic nmanovic merged commit 1a040a0 into develop Nov 24, 2018
@nmanovic nmanovic deleted the fix_upload_big_xml_files branch November 26, 2018 16:12
nmanovic added a commit that referenced this pull request Dec 29, 2018
* Bug has been fixed: impossible to lock/occlude object in AAM
* Bug has been fixed: invisible points actually are visible
* Bug has been fixed: impossible to close points after editing (#98)
* doc: grammatical cleanup of README.md (#107)
* Add info about development environment into CONTRIBUTING.md (#110)
* Now we store virtual URL instead of update it in the browser address bar (#112)
* Copy URL, Frame URL and object URL functionality in a context menu
* Bug has been fixed: label UIs don't update after changelabel (#109)
* Common escape button for exit from creating/groupping/merging/pasting/aam
* Switch outside/keyframe shortkeys
* Fix django vulnerability (#121)
* Add analytics component (#118)
* Incremental save of annotations (#120)
* Create task timeout 1h -> 4h. (#136)
* OpenVino integration (#134)
* Update README.md (#138)
* Add an extra field into meta section of a dump file (#149)
* Job status was implemented (#153)
* Back link to task from annotation view (#156)
* Change a task with labels and attributes in admin panel (#157)
* Permissions per tasks and jobs (#185)
* Fix context menu, text visibility for small images (#202)
* Fixed: both context menu are opened simultaneously
* Fixed: shape can be unavailable behind text
* Fixed: invisible text outside frame
* Fix upload big xml files for tasks (#199)
* Add Questions section to Readme.md (#226)
* Fixed labels order (#242)
* Propagate behaviour has been updated in cases with a different resolution (#246)
* Updated the guide and images (#241)
* Fix number attribute for float numbers. (#258)
TOsmanov pushed a commit to TOsmanov/cvat that referenced this pull request Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants