Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue related with deactivated nuclio dashboard #2008

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Aug 10, 2020

Motivation and context

Resolved #1965

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Now:

  • CVAT works when nuclio dashboard is off
  • UI shows message exactly about getting models, not about wrong plugin initialization
  • Check functions always return true/false

@bsekachev bsekachev added the bug Something isn't working label Aug 10, 2020
@coveralls
Copy link

coveralls commented Aug 10, 2020

Pull Request Test Coverage Report for Build 6855

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 68.901%

Files with Coverage Reduction New Missed Lines %
cvat/apps/engine/media_extractors.py 7 75.22%
Totals Coverage Status
Change from base Build 6850: -0.03%
Covered Lines: 11121
Relevant Lines: 15658

💛 - Coveralls

@bsekachev bsekachev merged commit 2c66102 into develop Aug 11, 2020
@bsekachev bsekachev deleted the bs/serverless_fix branch August 12, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When developing without Docker it always need to run nuclio container
3 participants