Cypress test for issue 1870 #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6896
💛 - Coveralls |
bsekachev
reviewed
Aug 11, 2020
Comment on lines
52
to
54
| .type('{leftarrow}{leftarrow}ee') | ||
| cy.get('.ant-input') | ||
| .should('have.value', newLabelAttrValue) |
There was a problem hiding this comment.
Can we unite it to the same chain without extra cy.get()?
There was a problem hiding this comment.
Yes, we can. I've reworked this part of the code a bit.
| cy.createShape(309, 431, 616, 671) | ||
| }) | ||
| it('Check what cursor doesn\'t automatically jumps at the end of the word', () => { | ||
| cy.get('.ant-row > .ant-collapse > .ant-collapse-item > .ant-collapse-header > span') |
There was a problem hiding this comment.
Not really reliable selector. It is better to use an identificator before. Here can be a lot of collapses in the future.
There was a problem hiding this comment.
I tried to shorten selector.
Refactoring the test code.
bsekachev
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Add Cypress test for issue 1870
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.