Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Canvas is busy #2437

Merged
merged 5 commits into from
Nov 17, 2020
Merged

Fixed: Canvas is busy #2437

merged 5 commits into from
Nov 17, 2020

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Nov 16, 2020

Motivation and context

Resolve #1922

How has this been tested?

Manual testing
@dvkruchinin Could you please write a test for the issue.
Scenario is:

  1. Open a job (should contain at least two images)
  2. Draw a shape on the first image
  3. Draw a shape on the second image
  4. Switch player back button mode to "back with a filter" (right click by the button and select)
  5. Start resizing (or dragging) a shape on the second frame
  6. Press the shortcut [D] to go to the first frame
  7. CVAT goes to fail view before the fix and nothing happens after fix

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added bug Something isn't working need test labels Nov 16, 2020
@coveralls
Copy link

coveralls commented Nov 16, 2020

Coverage Status

Coverage increased (+0.02%) to 62.831% when pulling 4ef1de0 on bs/fixed_issue_1922 into f0d99ee on develop.

@dvkruchinin
Copy link
Contributor

Sure. The test will be written.

@bsekachev bsekachev merged commit 2afc4fc into develop Nov 17, 2020
@bsekachev bsekachev deleted the bs/fixed_issue_1922 branch November 17, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canvas is busy. Action: drag
4 participants