Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with hung web worker #3096

Merged
merged 3 commits into from
Apr 20, 2021

Conversation

maximusunc
Copy link
Contributor

@maximusunc maximusunc commented Apr 15, 2021

  • Added upper limit to stop property of active chunk request

Motivation and context

Fixes #3080. The unzip_imgs web worker was not getting terminated when loading the last chunk in a task. I added a stopFrame limit to the chunk request so that the web worker gets properly terminated once it unzips all images.

How has this been tested?

I manually tested this by uploading 71 frames, all 2048 x 2448 to exceed the cache limit, and made sure that the web worker is correctly terminated after loading the last chunk. I also made sure that scrolling back through the previous frames worked and that frames that had been removed from the cache are successfully loaded back in.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@coveralls
Copy link

coveralls commented Apr 15, 2021

Coverage Status

Coverage increased (+0.04%) to 74.092% when pulling d3501d0 on maximusunc:mw/fix_hung_webworker into d2e4ee4 on openvinotoolkit:develop.

@nmanovic
Copy link
Contributor

@maximusunc , thanks for the contribution. Could you please add information about the fix into CHANGELOG.md?

@nmanovic
Copy link
Contributor

@maximusunc , could you please update the version of cvat-core? Run npm version patch command.

* Added upper limit to stop property of active chunk request
@maximusunc
Copy link
Contributor Author

Hi @nmanovic Looking at the test output, it looks like the tests timed out while running some canvas3d tests. I don't think my changes had anything to do with this test failure, but I will wait to hear back from you.

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maximusunc , thanks for the fix. For we it looks fine. All checks for the PR is OK.

@nmanovic nmanovic merged commit 8a635b1 into cvat-ai:develop Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI fails to load previously cached frames when working with large images
4 participants