Fixed UI fails when inactive user is assigneed to a task/job #3343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsekachev
commented
Jun 17, 2021
| @@ -157,7 +155,7 @@ Cypress.Commands.add('submitReview', (decision, user) => { | |||
| cy.get('.cvat-submit-review-dialog').within(() => { | |||
| cy.contains(new RegExp(`^${decision}$`, 'g')).click(); | |||
| if (decision === 'Review next') { | |||
| cy.intercept('GET', `/api/v1/users?is_active=true&search=${user}&limit=10`).as('searchUsers'); | |||
| cy.intercept('GET', `/api/v1/users?search=${user}&limit=10&is_active=true`).as('searchUsers'); | |||
There was a problem hiding this comment.
@dvkruchinin
Cypress tests failed because of this line. We do not really control the order of query parameters in these URLs (and probably we do not want to control it). Does cypress require exact order or maybe do you have ideas on how to improve it?
There was a problem hiding this comment.
Yes, the order must be followed. But in this case I think it can be processed through wildcard
cy.intercept('GET', '/api/v1/users*').as('searchUsers');
Yes. A test will be prepared. |
nmanovic
approved these changes
Jun 18, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Resolved #3339
How has this been tested?
Manual testing.
@dvkruchinin Can we prepare a test for the issue?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.