Server test. Combined image and directory extractors using shared storage #3428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, merge develop. The PR shows extra changes. |
…o ms/test_for_fixed_issue_3123
Done. |
bsekachev
reviewed
Jul 19, 2021
| } | ||
|
|
||
| # create task with server | ||
| self._create_task(task, image_data) |
There was a problem hiding this comment.
Can we also check a number of images in the created task?
| os.makedirs(main_path) | ||
| main_images = ["people.jpeg", "street_1.jpeg", "street_2.jpeg", "street_3.jpeg"] | ||
| for img in main_images: | ||
| image = Image.new('RGB', size=(100, 50)) |
There was a problem hiding this comment.
I suppose we can create the image once before the loop
| for img in main_images: | ||
| image = Image.new('RGB', size=(100, 50)) | ||
| image.save(osp.join(main_path, img), "JPEG") | ||
| image.save(osp.join(main_path, "street.png"), "PNG") |
There was a problem hiding this comment.
Can we get file extension from image name (with os.path.splitext) and put the operator to the loop above?
| os.makedirs(subdir_path) | ||
| subdir_images = ["image_4.jpeg", "image_5.jpeg", "image_6.jpeg"] | ||
| for img in subdir_images: | ||
| image = Image.new('RGB', size=(100, 50)) |
|
@bsekachev all comments are resolved. |
bsekachev
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Test scenario #3123
Fixed in #3424
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.