Project backups #3852
Project backups #3852
Conversation
azhavoro
requested review from
bsekachev,
nmanovic and
zhiltsov-max
as code owners
azhavoro
force-pushed
the
az/project_backup
branch
from
80f30a2
to
03b14d4
Compare
|
@azhavoro , could you please add CHANGELOG? Please add some screenshots into the description of the PR as well, summarize changes which were done. It will help me in the future to prepare the next release and also understand changes not from code but from the description. |
|
@azhavoro , it looks really good. I found two problems:
|
|
One more problem. When I backup the project for the first time, I get the following error:
If I press the backup project again, the operation is successful. |
|
|
Could not reproduce with new projects |
|
Some elements are not aligned as expected (my resolution is 3440x1440):
Need to add space between loading icon and text Some attributes are not restored. See example below: Exported annotations Restored task (true is a default value) |
|
Subset is not backed up to the file. Always: As far as I understand we do not backup these fields: |
|
I created a project task with these parameters: And can't dump the project anymore: Created task is: Jobs can be opened. I can share the file if you need. |
|
@azhavoro , could you please resolve conflicts? |
| @@ -21,7 +21,7 @@ class TokenAuthentication(_TokenAuthentication): | |||
| def authenticate(self, request): | |||
| auth = super().authenticate(request) | |||
| session = getattr(request, 'session') | |||
| if auth is not None and session.session_key is None: | |||
| if auth is not None and (session.session_key is None or (not session.modified and not session.load())): | |||
There was a problem hiding this comment.
@azhavoro , could you please put here some comments to understand these changes.
| return backup.export(db_project, request) | ||
|
|
||
| @action(detail=False, methods=['POST']) | ||
| def backup(self, request, pk=None): |
There was a problem hiding this comment.
@azhavoro , It looks like instead of POST /api/v1/tasks/backup we should have POST /api/v1/tasks with a corresponding data type. Also I don't like that for projects we create an empty project and after that import a dataset and for backup with have another approach. For creating tasks we have also two steps: create a tasks and send data after that.
Let's keep it as is for now and try to find a common solution later
@Marishka17 , please look at the inconsistency. It is something which we need to solve during REST API redesign.
Motivation and context
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.