-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GCS #3919
Support GCS #3919
Conversation
provider_type = models.CharField(max_length=20, choices=CloudProviderChoice.choices()) | ||
resource = models.CharField(max_length=63) | ||
resource = models.CharField(max_length=222) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Marishka17 , you can even have 255 (just in case). I really don't think that we have to be very strict here.
cvat-ui/src/components/create-cloud-storage-page/cloud-storage-form.tsx
Outdated
Show resolved
Hide resolved
@@ -170,15 +198,37 @@ export default function CreateCloudStorageForm(props: Props): JSX.Element { | |||
duration: 15, | |||
}); | |||
} | |||
}, [cloudStorage]); | |||
}, [cloudStorageId]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
effect callback also depends on cloudStorage
cvat-ui/src/components/create-cloud-storage-page/cloud-storage-form.tsx
Outdated
Show resolved
Hide resolved
cvat-ui/src/components/create-cloud-storage-page/cloud-storage-form.tsx
Outdated
Show resolved
Hide resolved
className: 'cvat-incorrect-add-region-notification', | ||
}); | ||
} else { | ||
const regionsCopy = regions; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hardly think it is a copy, that is probably link to the same object. Check if regions
contains newRegionKey
after it was inserted to regionsCopy
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you need exactly copy, maybe better to use Object and create a shallow copy this way: const copy = { ...source }
…-form.tsx Co-authored-by: Boris Sekachev <boris.sekachev@intel.com>
…-form.tsx Co-authored-by: Boris Sekachev <boris.sekachev@intel.com>
@nmanovic, Could you please take a look at the server part of this PR? |
@@ -809,6 +811,7 @@ class CloudStorageSerializer(serializers.ModelSerializer): | |||
key = serializers.CharField(max_length=20, allow_blank=True, required=False) | |||
secret_key = serializers.CharField(max_length=40, allow_blank=True, required=False) | |||
key_file_path = serializers.CharField(max_length=64, allow_blank=True, required=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Marishka17 , I believe key_file_path has to be removed. What do you think? Probably you can do that in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I added the option to upload a key file for a case when CVAT instance is deployed remotely. But now I've looked at it from a different side. Ok, I'll prepare PR for this.
…o openvinotoolkit-develop * 'develop' of https://github.com/openvinotoolkit/cvat: (181 commits) Cypress. Update case 105. Add check "Google cloud storage" provider fields. (cvat-ai#3980) Cypress. Fix case 108 for Firefox. (cvat-ai#3981) update project section (cvat-ai#3979) Cypress. Test "Rotated bounding boxes" (cvat-ai#3961) Issue deleting (cvat-ai#3952) Remove key_file_path field (cvat-ai#3959) update the doc for change default hostname or port (cvat-ai#3915) CVAT_server. Test for "Project updated time". (cvat-ai#3953) fix: cvat/requirements/base.txt to reduce vulnerabilities (cvat-ai#3970) Fix notification (cvat-ai#3960) Update documentation for China users (cvat-ai#3946) Support GCS (cvat-ai#3919) Cypress. Update the test for check issue 3810. (cvat-ai#3900) Update the documentation about the smooth image option (cvat-ai#3947) Project tasks pagination (cvat-ai#3910) Update documentation about review mode (cvat-ai#3944) Preserve the order of the label attributes in the object item details. (cvat-ai#3945) Added smooth image option (cvat-ai#3933) Fixed issue: autoborder points are visible for invisible shapes (cvat-ai#3931) Add FiftyOne to partners list (cvat-ai#3943) ...
* openvinotoolkit-develop: (181 commits) Cypress. Update case 105. Add check "Google cloud storage" provider fields. (cvat-ai#3980) Cypress. Fix case 108 for Firefox. (cvat-ai#3981) update project section (cvat-ai#3979) Cypress. Test "Rotated bounding boxes" (cvat-ai#3961) Issue deleting (cvat-ai#3952) Remove key_file_path field (cvat-ai#3959) update the doc for change default hostname or port (cvat-ai#3915) CVAT_server. Test for "Project updated time". (cvat-ai#3953) fix: cvat/requirements/base.txt to reduce vulnerabilities (cvat-ai#3970) Fix notification (cvat-ai#3960) Update documentation for China users (cvat-ai#3946) Support GCS (cvat-ai#3919) Cypress. Update the test for check issue 3810. (cvat-ai#3900) Update the documentation about the smooth image option (cvat-ai#3947) Project tasks pagination (cvat-ai#3910) Update documentation about review mode (cvat-ai#3944) Preserve the order of the label attributes in the object item details. (cvat-ai#3945) Added smooth image option (cvat-ai#3933) Fixed issue: autoborder points are visible for invisible shapes (cvat-ai#3931) Add FiftyOne to partners list (cvat-ai#3943) ...
Motivation and context
Resolve #3760
How has this been tested?
Manually + extended jest tests
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
- [ ] I have updated the license header for each file (see an example below)