Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress. New organization pipeline. #4143

Conversation

dvkruchinin
Copy link
Contributor

Motivation and context

Adding a test to test the basic capabilities of the new functionality.
The test system has been improved in the form of adding css classes.
Added Cypress commands. Solved eslint errors in some files.

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev self-assigned this Jan 13, 2022
…o dkru/cypress-case-113-new-organization-pipeline
@dvkruchinin dvkruchinin changed the title Cypress. New organization pipeline. [WIP] Cypress. New organization pipeline. Jan 17, 2022
@dvkruchinin dvkruchinin changed the title [WIP] Cypress. New organization pipeline. Cypress. New organization pipeline. Jan 17, 2022
Comment on lines 202 to 207
cy.logout();
cy.login(secondUserName, secondUser.password);
cy.checkOrganizationExists(organizationParams.shortName);
cy.contains('.cvat-item-task-name', taskName).should('exist');
cy.goToProjectsList();
cy.get('.cvat-empty-projects-list').should('exist');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment about this case:
Need to activate organization first. The second user cannot see the task if do not switch organization context (now the user sees the task, but it is a bug, will be fixed soon). The second user also sees the project (when organization is activated) on projects page (this is one more bug, will be fixed)

Copy link
Member

@bsekachev bsekachev Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for the second bug here: #4201

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged last changed from develop with fix #4201. The second bug is not preproducing. I also thought it would be good to separate some tests and add additional steps. Please take a look.
I have commented out the checks that are not working now.

@bsekachev
Copy link
Member

Generally everything fine, just please fix the latest comment and let's wait for bugfixes, than I will merge this patch.

cy.contains('.cvat-text-color', oldName).clear().type(`${newName}{Enter}`);
cy.contains('.cvat-task-details-task-name', newName).should('exist');
});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @dvkruchinin

Text for ellipses has been added here #4229

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bsekachev,

Great!
I`ll update the cypress command implemented in #4215

@bsekachev
Copy link
Member

@dvkruchinin

Could you please merge develop and uncomment corresponding tests?

@dvkruchinin
Copy link
Contributor Author

@dvkruchinin

Could you please merge develop and uncomment corresponding tests?

@bsekachev
Sure. Done.
But I also had to finalize some tests.
The user to whom the job is assigned can no longer open a job via a direct link without activating the organization.
The user excluded from the organization now does not see the task, even if it is assigned to him.

@bsekachev
Copy link
Member

@dvkruchinin

The user to whom the job is assigned can no longer open a job via a direct link without activating the organization.
The user excluded from the organization now does not see the task, even if it is assigned to him.

This is expected.

@bsekachev bsekachev merged commit e212d57 into cvat-ai:develop Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants