Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YOLO adapted version of PASCAL VOC converter.py #454

Merged
merged 14 commits into from
May 31, 2019

Conversation

dntxos
Copy link
Contributor

@dntxos dntxos commented May 16, 2019

Since we use Darknet / Yolo and decided to change our annotation tool from SCALABEL to CVAT, it was necessary to write export scripts for YOLO format

@dntxos
Copy link
Contributor Author

dntxos commented May 16, 2019

Wow. Codacy/PR Quality Review seems to found issues in line that i have exactly copied from line above and changes some characters.

https://app.codacy.com/app/nmanovic/cvat/pullRequest?prid=3597669

@dntxos
Copy link
Contributor Author

dntxos commented May 16, 2019

Hi @nmanovic . I hope this PR can contribute with issue #275

@nmanovic
Copy link
Contributor

Hi @dntxos , thanks for your contribution! Our team really appreciate that. Please let us a couple of days to review and try. I will come back with a feedback shortly!

if ("sessionid" in httpclient.cookies):
sessionid = httpclient.cookies["sessionid"]

url = urlbase+"/api/v1/tasks/"+str(taskid)+"/frames/"+ str(frameid)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dntxos , I general I don't think that it is a good idea to contact CVAT instance to get frames. Frames which CVAT provides using the API don't have good quality. It isn't something which should be used for training. Quality of frames should be enough to do annotation. They can be compressed and this is why we have "image quality" parameter when an annotation task is created.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can think that user provides you all necessary data. Thus your code will be simpler.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. This code download frames from CVAT only when a username is passed. It is an optional parameter. Since in my scenario everything works locally and i loaded with good quality (not standard 50), this seemed useful to me. I can remove from the code if you prefer. ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dntxos, if the code is useful for you let's keep it. I will try to test your code and if I don't see any other issues I will merge. Thanks again for your contribution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmanovic, cool! Thx for your feedback. It is an honor to contribute to this amazing project. Our annotation time has considerably reduced with CVAT. 🤩👏👏👏

@nmanovic
Copy link
Contributor

@dntxos , also need to add information about the feature to CHANGELOG.md

@@ -0,0 +1,3 @@
argparse>=1.1
lxml>=3.5.0
glog>=0.3.1s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo here. I will fix.

@nmanovic nmanovic merged commit a311648 into cvat-ai:develop May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants