AWS AccessKey and SecretKey set to 129 char long #4584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebagarayco , thanks for the contribution! Please expect delays in our review for now. |
bsekachev
reviewed
May 18, 2022
| @@ -74,8 +74,8 @@ export default function CreateCloudStorageForm(props: Props): JSX.Element { | |||
| const fakeCredentialsData = { | |||
| accountName: 'X'.repeat(24), | |||
| sessionToken: 'X'.repeat(300), | |||
| key: 'X'.repeat(20), | |||
| secretKey: 'X'.repeat(40), | |||
| key: 'X'.repeat(129), | |||
There was a problem hiding this comment.
Could you explain this change, please?
|
Hi, @sebagarayco, thanks for the contribution! Are you still going to contribute to us? If so, could you please resolve conflicts in this PR? |
5 tasks
|
I will close the PR for now. Please, do not hesitate to reopen if you are ready to respond in the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
How has this been tested?
Checklist
developbranch- [ ] I have added a description of my changes into CHANGELOG file- [] I have updated the documentation accordingly- [ ] I have added tests to cover my changes- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
- [ ] I have updated the license header for each file (see an example below)